fix: don't reinitialize created accounts #6534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/fix-init-created-account
branch
from
0563356
to
d8bc3ac
Compare
Evalir
approved these changes
Dec 6, 2023
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6032
There was an edge case where the initialization function incorrectly replaced the AccountInfo of created accounts with the account info fetched from the fork.
The reason this function exists, is so we can reinitialize accounts that were touched before a fork was active with the account info of the fork. This is required so that the fork can use real accounts even if the account has been loaded previously. for example a getNonce check.
However, newly created accounts should be exempt from this check.